Fix a typo in generating URL for us-based regions#17
Open
grishick wants to merge 1 commit intoDeveloper-Amit:masterfrom
Open
Fix a typo in generating URL for us-based regions#17grishick wants to merge 1 commit intoDeveloper-Amit:masterfrom
grishick wants to merge 1 commit intoDeveloper-Amit:masterfrom
Conversation
|
Thanks for your PR man. It saved me a lot of time. I was not setting the s3Url and did not realize that the URL generated was wrong. |
|
Is this going to be merged at any point? |
|
Thx for the fix and for the info. Just to outline the workaround for everyone while we wait for this get merged: const bucketName = "my-bucket";
const region = "us-east-1";
const config = {
bucketName,
region,
accessKeyId: "my-access-key-id",
secretAccessKey: "my-secret-access-key",
// this is the required line to fix your error
s3Url: `https://${bucketName}.s3.${region}.amazonaws.com`,
};
const ReactS3Client = new S3(config);
// etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for creating this package! I was using it today and I was getting errors until I realized that there is a typo in how S3 URL is being generated for non-Chinese based regions. With this fix, the package works w/o custom URL on non-Chinese regions.